{"componentChunkName":"component---node-modules-rocketseat-gatsby-theme-docs-core-src-templates-docs-query-js","path":"/manual-review/UltraFeeder-UFR","result":{"data":{"mdx":{"id":"5884a672-6bd4-5e0b-b1cb-b556f97bf05e","excerpt":"UFR-01M: Inefficient Redemption Fulfilment Structure Type Severity Location Gas Optimization UltraFeeder.sol:L186-L195 ,  L198-L208 ,  L212-L222 Description…","fields":{"slug":"/manual-review/UltraFeeder-UFR/"},"frontmatter":{"title":"UltraFeeder Manual Review Findings","description":"Contains all the findings that relate to manual review on the contract codebase","image":null,"disableTableOfContents":null},"body":"var _excluded = [\"components\"];\n\nfunction _extends() { _extends = Object.assign || function (target) { for (var i = 1; i < arguments.length; i++) { var source = arguments[i]; for (var key in source) { if (Object.prototype.hasOwnProperty.call(source, key)) { target[key] = source[key]; } } } return target; }; return _extends.apply(this, arguments); }\n\nfunction _objectWithoutProperties(source, excluded) { if (source == null) return {}; var target = _objectWithoutPropertiesLoose(source, excluded); var key, i; if (Object.getOwnPropertySymbols) { var sourceSymbolKeys = Object.getOwnPropertySymbols(source); for (i = 0; i < sourceSymbolKeys.length; i++) { key = sourceSymbolKeys[i]; if (excluded.indexOf(key) >= 0) continue; if (!Object.prototype.propertyIsEnumerable.call(source, key)) continue; target[key] = source[key]; } } return target; }\n\nfunction _objectWithoutPropertiesLoose(source, excluded) { if (source == null) return {}; var target = {}; var sourceKeys = Object.keys(source); var key, i; for (i = 0; i < sourceKeys.length; i++) { key = sourceKeys[i]; if (excluded.indexOf(key) >= 0) continue; target[key] = source[key]; } return target; }\n\n/* @jsxRuntime classic */\n\n/* @jsx mdx */\nvar _frontmatter = {\n  \"title\": \"UltraFeeder Manual Review Findings\",\n  \"description\": \"Contains all the findings that relate to manual review on the contract codebase\"\n};\nvar layoutProps = {\n  _frontmatter: _frontmatter\n};\nvar MDXLayout = \"wrapper\";\nreturn function MDXContent(_ref) {\n  var components = _ref.components,\n      props = _objectWithoutProperties(_ref, _excluded);\n\n  return mdx(MDXLayout, _extends({}, layoutProps, props, {\n    components: components,\n    mdxType: \"MDXLayout\"\n  }), mdx(\"h2\", {\n    \"id\": \"span-idufr-01mufr-01m-inefficient-redemption-fulfilment-structurespan\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h2\",\n    \"href\": \"#span-idufr-01mufr-01m-inefficient-redemption-fulfilment-structurespan\",\n    \"aria-label\": \"span idufr 01mufr 01m inefficient redemption fulfilment structurespan permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), mdx(\"span\", {\n    id: \"UFR-01M\"\n  }, \"UFR-01M: Inefficient Redemption Fulfilment Structure\")), mdx(\"table\", null, mdx(\"thead\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"thead\"\n  }, mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Type\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Severity\"), mdx(\"th\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, \"Location\"))), mdx(\"tbody\", {\n    parentName: \"table\"\n  }, mdx(\"tr\", {\n    parentName: \"tbody\"\n  }, mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"/reports/ultra-yield-vault-contracts-68aaf30fb32fb20018fa5e24/appendix/finding-types#gas-optimization\"\n  }, \"Gas Optimization\")), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"img\", {\n    parentName: \"td\",\n    \"className\": \"o-severity o-informational\",\n    \"src\": \"https://omniscia.io/report-assets/informational.png\"\n  })), mdx(\"td\", {\n    parentName: \"tr\",\n    \"align\": null\n  }, mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/UltraYield/contracts/blob/b4cf59242df2566e10e0670040658f8d851cba1e/src/vaults/UltraFeeder.sol#L186-L195\"\n  }, \"UltraFeeder.sol:L186-L195\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/UltraYield/contracts/blob/b4cf59242df2566e10e0670040658f8d851cba1e/src/vaults/UltraFeeder.sol#L198-L208\"\n  }, \"L198-L208\"), \", \", mdx(\"a\", {\n    parentName: \"td\",\n    \"href\": \"https://github.com/UltraYield/contracts/blob/b4cf59242df2566e10e0670040658f8d851cba1e/src/vaults/UltraFeeder.sol#L212-L222\"\n  }, \"L212-L222\"))))), mdx(\"h3\", {\n    \"id\": \"description\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#description\",\n    \"aria-label\": \"description permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Description:\"), mdx(\"p\", null, \"The referenced redemption fulfilment function structure is complicated unnecessarily, relying on before, after, as well as extra after-execution logic for redemption fulfilments.\"), mdx(\"h3\", {\n    \"id\": \"impact\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#impact\",\n    \"aria-label\": \"impact permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Impact:\"), mdx(\"p\", null, \"While this is a gas optimization, the complexity of the code is prone to error and must be simplified.\"), mdx(\"h3\", {\n    \"id\": \"example\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#example\",\n    \"aria-label\": \"example permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Example:\"), mdx(\"pre\", null, mdx(\"code\", {\n    parentName: \"pre\",\n    \"className\": \"language-sol\",\n    \"metastring\": \"title=src/vaults/UltraFeeder.sol highlight={10,23,24,37,38} lineNumbers=true lineOffset=183\",\n    \"title\": \"src/vaults/UltraFeeder.sol\",\n    \"highlight\": \"{10,23,24,37,38}\",\n    \"lineNumbers\": \"true\",\n    \"lineOffset\": \"183\"\n  }, \"/// @dev Before fulfill redeem - transfer funds from fundsHolder to vault\\n/// @dev \\\"assets\\\" will already be correct given the token user requested\\nfunction beforeFulfillRedeem(address _asset, uint256 assets, uint256 shares) internal override {\\n    IUltraVault mainVault_ = mainVault();\\n    // Fulfill redeem in main vault. Returns asset units\\n    mainVault_.fulfillRedeemOfAsset(_asset, shares, address(this));\\n    uint256 mainAssetsClaimed = mainVault_.redeemAsset(_asset, shares, address(this), address(this));\\n\\n    // Deduct the expected withdrawal fee from the total amount of assets\\n    uint256 expectedAssetsAfterFees = assets - mainVault_.calculateWithdrawalFee(assets);\\n    require(mainAssetsClaimed == expectedAssetsAfterFees, AssetNumberMismatch());\\n}\\n\\n/// @dev Internal fulfill redeem request logic\\nfunction _fulfillRedeemOfAsset(\\n    address _asset,\\n    uint256 assets,\\n    uint256 shares,\\n    address controller\\n) internal override returns (uint256) {\\n    uint256 assetsFulfilled = super._fulfillRedeemOfAsset(_asset, assets, shares, controller);\\n    // Deduct the expected withdrawal fee from the total amount of assets\\n    uint256 withdrawalFee = mainVault().calculateWithdrawalFee(assetsFulfilled);\\n    return assetsFulfilled - withdrawalFee;\\n}\\n\\n/// @dev Hook for inheriting contracts after fulfill redeem\\n/// @dev Correct claimable redeem amounts to account for underlying vault fees\\nfunction afterFulfillRedeem(\\n    address _asset,\\n    uint256 assets,\\n    uint256, // shares\\n    address controller\\n) internal override {\\n    // The base implementation has added `_assets` to the claimable assets\\n    // We need to calculate the withdrawal fee and deduct it from the claimable assets\\n    uint256 withdrawalFee = mainVault().calculateWithdrawalFee(assets);\\n    _consumeClaimableRedeem(controller, _asset, withdrawalFee, 0);\\n}\\n\")), mdx(\"h3\", {\n    \"id\": \"recommendation\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#recommendation\",\n    \"aria-label\": \"recommendation permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Recommendation:\"), mdx(\"p\", null, \"We advise the code of the \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/UltraYield/contracts/blob/b4cf59242df2566e10e0670040658f8d851cba1e/src/vaults/BaseControlledAsyncRedeem.sol#L959-L983\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"BaseControlledAsyncRedeem::_fulfillRedeemOfAsset\")), \" function to be updated to utilize a return value by the \", mdx(\"a\", {\n    parentName: \"p\",\n    \"href\": \"https://github.com/UltraYield/contracts/blob/b4cf59242df2566e10e0670040658f8d851cba1e/src/vaults/UltraFeeder.sol#L186-L195\"\n  }, mdx(\"inlineCode\", {\n    parentName: \"a\"\n  }, \"UltraFeeder::beforeFulfillRedeem\")), \" function, permitting the actual assets to be redeemed to be yielded and thus simplifying the code greatly.\"), mdx(\"h3\", {\n    \"id\": \"alleviation-28f27853965de07fb79f4f2b5fed696d35120032\",\n    \"style\": {\n      \"position\": \"relative\"\n    }\n  }, mdx(\"a\", {\n    parentName: \"h3\",\n    \"href\": \"#alleviation-28f27853965de07fb79f4f2b5fed696d35120032\",\n    \"aria-label\": \"alleviation 28f27853965de07fb79f4f2b5fed696d35120032 permalink\",\n    \"className\": \"anchor before\"\n  }, mdx(\"svg\", {\n    parentName: \"a\",\n    \"aria-hidden\": \"true\",\n    \"focusable\": \"false\",\n    \"height\": \"16\",\n    \"version\": \"1.1\",\n    \"viewBox\": \"0 0 16 16\",\n    \"width\": \"16\"\n  }, mdx(\"path\", {\n    parentName: \"svg\",\n    \"fillRule\": \"evenodd\",\n    \"d\": \"M4 9h1v1H4c-1.5 0-3-1.69-3-3.5S2.55 3 4 3h4c1.45 0 3 1.69 3 3.5 0 1.41-.91 2.72-2 3.25V8.59c.58-.45 1-1.27 1-2.09C10 5.22 8.98 4 8 4H4c-.98 0-2 1.22-2 2.5S3 9 4 9zm9-3h-1v1h1c1 0 2 1.22 2 2.5S13.98 12 13 12H9c-.98 0-2-1.22-2-2.5 0-.83.42-1.64 1-2.09V6.25c-1.09.53-2 1.84-2 3.25C6 11.31 7.55 13 9 13h4c1.45 0 3-1.69 3-3.5S14.5 6 13 6z\"\n  }))), \"Alleviation (28f27853965de07fb79f4f2b5fed696d35120032):\"), mdx(\"p\", null, \"The Ultra Yield team evaluated this exhibit and opted to not implement the optimization outlined as it would significantly affect the logic of the \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"UltraVault\"), \" and \", mdx(\"inlineCode\", {\n    parentName: \"p\"\n  }, \"UltraFeeder\"), \" contracts.\"));\n}\n;\nMDXContent.isMDXComponent = true;","headings":[{"depth":2,"value":"<span id=\"UFR-01M\">UFR-01M: Inefficient Redemption Fulfilment Structure</span>"},{"depth":3,"value":"Description:"},{"depth":3,"value":"Impact:"},{"depth":3,"value":"Example:"},{"depth":3,"value":"Recommendation:"},{"depth":3,"value":"Alleviation (28f27853965de07fb79f4f2b5fed696d35120032):"}]}},"pageContext":{"slug":"/manual-review/UltraFeeder-UFR/","prev":{"label":"BaseControlledAsyncRedeem.sol (BCA-M)","link":"/manual-review/BaseControlledAsyncRedeem-BCA"},"next":{"label":"UltraVault.sol (UVT-M)","link":"/manual-review/UltraVault-UVT"}}},"staticQueryHashes":["1954253342","2328931024","2501019404","973074209"]}